[
https://issues.apache.org/jira/browse/SOLR-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301541#comment-15301541
]
Varun Thacker commented on SOLR-9163:
-------------------------------------
Indeed!
I think the main problem here is that we have too many example configs. So over
time when new features get added, there is no "rule" as to which configsets
should be updated with an example of the feature/setting.
Let's take the "techproducts" VS "data_driven" config set. I think they should
only be different from each other in 3 things
- "techproducts" should come with pre-defined fields which are part of the
sample document set.
- "techproducts" comes with a pre-defined "/browse" request handler
- "data_driven" comes with a custom "add-unknown-fields-to-the-schema" update
processor which makes the example configset schemaless.
But like you said its pretty different currently and confusing.
I feel we should just copy over the techproducts solrconfig to data_driven ,
remove "/browse" and add "add-unknown-fields-to-the-schema" .
Using the start scripts to make use of APIs to add the extra configurations
seems trappy as well ( in case we want one base config ). The config would then
be tied to start scripts.
Our tests uses inclusion - {{ <xi:include
href="solrconfig.snippet.randomindexconfig.xml"
xmlns:xi="http://www.w3.org/2001/XInclude"/>}} . So maybe we could do something
like this here to be able to share them better?
> Confusing solrconfig.xml in the downloaded solr*.zip
> ----------------------------------------------------
>
> Key: SOLR-9163
> URL: https://issues.apache.org/jira/browse/SOLR-9163
> Project: Solr
> Issue Type: Bug
> Reporter: Sachin Goyal
>
> Here are the solrconfig.xml when I download and unzip solr:
> {code}
> find . -name solrconfig.xml
> ./solr-5.5.1/example/example-DIH/solr/db/conf/solrconfig.xml
> ./solr-5.5.1/example/example-DIH/solr/mail/conf/solrconfig.xml
> ./solr-5.5.1/example/example-DIH/solr/rss/conf/solrconfig.xml
> ./solr-5.5.1/example/example-DIH/solr/solr/conf/solrconfig.xml
> ./solr-5.5.1/example/example-DIH/solr/tika/conf/solrconfig.xml
> ./solr-5.5.1/example/files/conf/solrconfig.xml
> ./solr-5.5.1/server/solr/configsets/basic_configs/conf/solrconfig.xml
> ./solr-5.5.1/server/solr/configsets/data_driven_schema_configs/conf/solrconfig.xml
> ./solr-5.5.1/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
> {code}
> Most likely, the ones I want to use are in server/solr/configsets, I assume.
> But then which ones among those three?
> Searching online does not provide much detailed information.
> And diff-ing among them yields even more confusing results.
> Example: When I diff basic_configs/conf/solrconfig.xml with
> data_driven_schema_configs/conf/solrconfig.xml, I am not sure why the latter
> has these extra constrcuts?
> # solr.LimitTokenCountFilterFactory and all the comments around it.
> # deletionPolicy class="solr.SolrDeletionPolicy"
> # Commented out infoStream file="INFOSTREAM.txt"
> # Extra comments for "Update Related Event Listeners"
> # indexReaderFactory
> # And so for lots of other constructs and comments.
> The point is that it is difficult to find out exactly what extra features in
> the latter are making it data-driven. Hence it is difficult to know what
> features I am losing by not taking the data-driven-schema.
> It would be good to sync the above 3 files together (each file should have
> same comments and differ only in the configuration which makes them
> different). Also, some good documentation should be put online about them
> otherwise it is very confusing for non-committers and vanilla-users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
