[ 
https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

AngryDeveloper updated SOLR-9168:
---------------------------------
    Description: 
Right now the start script always uses $SOLR_TIP/bin/oom_solr.sh  to handle 
OutOfMemoryException. This script only kills instance of solr.

We need to do some additional things (e.g sent mail about this exception)

What do you think about adding possibility to set up own script?


Proposition:
{code}

if [ -z "$SOLR_OOM_SCRIPT" ]; then
  SOLR_OOM_SCRIPT=$SOLR_TIP/bin/oom_solr.sh 
fi

[...]

nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS \
        "-XX:OnOutOfMemoryError=$SOLR_OOM_SCRIPT $SOLR_PORT $SOLR_LOGS_DIR" \
        -jar start.jar "${SOLR_JETTY_CONFIG[@]}" \
        1>"$SOLR_LOGS_DIR/solr-$SOLR_PORT-console.log" 2>&1 & echo $! > 
"$SOLR_PID_DIR/solr-$SOLR_PORT.pid"
{code}

  was:
Right now the start script always uses $SOLR_TIP/bin/oom_solr.sh  to handle 
OutOfMemoryException. This script only kills instance of solr.

We need to do some additional things (e.g sent mail about this exception)

What do you think about adding possibility to set up own script?


Proposition:
{code}

if [ -z "$SOLR_OOM_SCRIPT" ]; then
  SOLR_OOM_SCRIPT=$SOLR_TIP/bin/oom_solr.sh 
fi

    nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS \
        "-XX:OnOutOfMemoryError=$SOLR_OOM_SCRIPT $SOLR_PORT $SOLR_LOGS_DIR" \
        -jar start.jar "${SOLR_JETTY_CONFIG[@]}" \
        1>"$SOLR_LOGS_DIR/solr-$SOLR_PORT-console.log" 2>&1 & echo $! > 
"$SOLR_PID_DIR/solr-$SOLR_PORT.pid"
{code}


> Add availability to specify own oom handing script
> --------------------------------------------------
>
>                 Key: SOLR-9168
>                 URL: https://issues.apache.org/jira/browse/SOLR-9168
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>    Affects Versions: 5.5.1
>            Reporter: AngryDeveloper
>            Priority: Minor
>              Labels: oom
>             Fix For: 5.5.1
>
>
> Right now the start script always uses $SOLR_TIP/bin/oom_solr.sh  to handle 
> OutOfMemoryException. This script only kills instance of solr.
> We need to do some additional things (e.g sent mail about this exception)
> What do you think about adding possibility to set up own script?
> Proposition:
> {code}
> if [ -z "$SOLR_OOM_SCRIPT" ]; then
>   SOLR_OOM_SCRIPT=$SOLR_TIP/bin/oom_solr.sh 
> fi
> [...]
> nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS \
>       "-XX:OnOutOfMemoryError=$SOLR_OOM_SCRIPT $SOLR_PORT $SOLR_LOGS_DIR" \
>         -jar start.jar "${SOLR_JETTY_CONFIG[@]}" \
>       1>"$SOLR_LOGS_DIR/solr-$SOLR_PORT-console.log" 2>&1 & echo $! > 
> "$SOLR_PID_DIR/solr-$SOLR_PORT.pid"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to