[
https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311847#comment-15311847
]
Adrien Grand commented on LUCENE-7307:
--------------------------------------
bq. Also I changed the return type from Collection<byte[]> to
Collection<BytesRef> because the sortedPackedPoints iterator already makes a
copy and returns that as BytesRef.
I think the byte[] version was better since it is consitent with
PointPangeQuery which exposes the low/high bounds as a byte[]? Also I don't
think it is true that the sortedPackedPoints iterator makes a copy: looking at
PrefixCodedTerms, it seems to be reusing the same BytesRef object?
Something else we should do is throwing a NoSuchElementException in the
Iterator whin upTo==size to comply with the Iterator API.
> Add getters to PointInSetQuery and PointRangeQuery classes
> ----------------------------------------------------------
>
> Key: LUCENE-7307
> URL: https://issues.apache.org/jira/browse/LUCENE-7307
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Priority: Trivial
> Attachments: LUCENE_7307.patch, LUCENE_7307.patch, LUCENE_7307.patch,
> LUCENE_7307.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
