[
https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317318#comment-15317318
]
Hoss Man commented on SOLR-5944:
--------------------------------
bq. Removed all non 3x, 4x codec suppression. They need to be suppressed as per
a comment from Mikhail. ...
that comment is over 2 years old, from a time when those codecs existed but did
not support updating doc values.
those codecs no longer exist (on either master or branch_6x) -- even if someone
had na existing index with segments from those codecs, they would not be
supported by any Solr 6.x version because they are more then 1 major version
old -- we only have to worry about Lucene5* codecs and higher.
bq. As of now, both will generate a new version. I think "inc" 0 should be
dropped, and "set" same value should be versioned. I'll check if behaviour in
this patch is at par with regular atomic updates; and if so, will open a
separate issue for this later.
yeah, sorry -- my point was: "whatever the current, non-patched, behavior is
for the version returned from these types of updates, we need to assert that
behavior is true here." -- we should not be changing any semantics here,
absolutely open a distinct issue for that if you think it makes sense as a
future improvement.
bq. I think we can do the same in TestStressInPlaceUpdates, by randomly setting
number of writer threads to 1 sometimes.
Isn't that still a cloud based test with multiple nodes/shards? Even with only
1 writer thread it's going ot be harder to debug then doing more randomized
testing in a single node test (via something like checkReplay as in my previous
suggestion)
bq. I couldn't find a way to do this (check RTG against uncommitted model) for
the TestInPlaceUpdate (now called TestInPlaceUpdatesStandalone in this patch).
This is based on SolrTestCaseJ4.
{{SolrTestCaseJ4.addAndGetVersion(...)}}
> Support updates of numeric DocValues
> ------------------------------------
>
> Key: SOLR-5944
> URL: https://issues.apache.org/jira/browse/SOLR-5944
> Project: Solr
> Issue Type: New Feature
> Reporter: Ishan Chattopadhyaya
> Assignee: Shalin Shekhar Mangar
> Attachments: DUP.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
> TestStressInPlaceUpdates.eb044ac71.beast-167-failure.stdout.txt,
> TestStressInPlaceUpdates.eb044ac71.beast-587-failure.stdout.txt,
> TestStressInPlaceUpdates.eb044ac71.failures.tar.gz,
> hoss.62D328FA1DEA57FD.fail.txt, hoss.62D328FA1DEA57FD.fail2.txt,
> hoss.62D328FA1DEA57FD.fail3.txt, hoss.D768DD9443A98DC.fail.txt,
> hoss.D768DD9443A98DC.pass.txt
>
>
> LUCENE-5189 introduced support for updates to numeric docvalues. It would be
> really nice to have Solr support this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
