Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/41#discussion_r66172805
--- Diff:
solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java ---
@@ -466,6 +466,8 @@ private void markTaskComplete(String id, String asyncId)
log.warn("Could not find and remove async call [" + asyncId + "]
from the running map.");
}
}
+
+ workQueue.remove(head);
--- End diff --
@markrmiller can you think of any reason not to do this? I don't
understand why currently getting things out of the queue takes an extra
iteration. I think my fix unmasked a latent problem exposed by
DeleteStatusTest; to get that test to pass I have to eagerly remove completed
items from the work queue, which seems correct to me. Not sure why we'd want
to wait for a loop-around to `cleanUpWorkQueue()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
