[
https://issues.apache.org/jira/browse/SOLR-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Chanan resolved SOLR-9199.
----------------------------------
Resolution: Fixed
Fix Version/s: 6.2
master (7.0)
> ZkController#publishAndWaitForDownStates logic is inefficient
> -------------------------------------------------------------
>
> Key: SOLR-9199
> URL: https://issues.apache.org/jira/browse/SOLR-9199
> Project: Solr
> Issue Type: Bug
> Reporter: Hrishikesh Gadre
> Assignee: Hrishikesh Gadre
> Fix For: master (7.0), 6.2
>
> Attachments: SOLR-9199.patch
>
>
> The following logic introduced as part of SOLR-8720 is inefficient.
> https://github.com/apache/lucene-solr/blob/6c0331b8309603eaaf14b6677afba5ffe99f16a3/solr/core/src/java/org/apache/solr/cloud/ZkController.java#L687-L712
> Specifically,
> * foundStates flag is set to TRUE before the for loop.
> * In the for loop we check if any replica on this node is not in the DOWN
> state. If yes, then foundStates = FALSE
> * If foundStates == TRUE then we break out of the loop and return.
> The problem here is that once foundStates is set to FALSE, it is never reset
> to TRUE. Hence we end up spending the whole 60 secs iterating over the
> collections even though all the replicas are marked as DOWN in later
> iterations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
