I can beast it a bit if that's useful....
On Tue, Jun 14, 2016 at 7:07 AM, David Smiley (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329554#comment-15329554 > ] > > David Smiley commented on SOLR-7374: > ------------------------------------ > > bq. One comment: Shouldn't we make BackupRepository an abstract class rather > than interface? We can only add default methods in Java 8, but branch6x is > still Java 7 right? > > No; we're all Java 8 now -- master & 6x. You must be thinking of 5x which > was Java 7. > >> Backup/Restore should provide a param for specifying the directory >> implementation it should use >> ----------------------------------------------------------------------------------------------- >> >> Key: SOLR-7374 >> URL: https://issues.apache.org/jira/browse/SOLR-7374 >> Project: Solr >> Issue Type: Bug >> Reporter: Varun Thacker >> Assignee: Mark Miller >> Fix For: 5.2, 6.0 >> >> Attachments: SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, >> SOLR-7374.patch >> >> >> Currently when we create a backup we use SimpleFSDirectory to write the >> backup indexes. Similarly during a restore we open the index using >> FSDirectory.open . >> We should provide a param called {{directoryImpl}} or {{type}} which will be >> used to specify the Directory implementation to backup the index. >> Likewise during a restore you would need to specify the directory impl which >> was used during backup so that the index can be opened correctly. >> This param will address the problem that currently if a user is running Solr >> on HDFS there is no way to use the backup/restore functionality as the >> directory is hardcoded. >> With this one could be running Solr on a local FS but backup the index on >> HDFS etc. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org