[
https://issues.apache.org/jira/browse/SOLR-7065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332488#comment-15332488
]
Mike Drob commented on SOLR-7065:
---------------------------------
Recently saw something that might be this. Started trying to bring your patch
up to current master, but ran into issues; some of the changes that you had in
this patch got committed as part of SOLR-7033. I also didn't understand the
advantage of returning an int instead of a boolean for sync. It looks like you
used it to provide a ternary indicator of error, no sync necessary, or sync
completed? That code changed a bunch with the fingerprinting from SOLR-8586.
A specific case that doesn't make sense was
{code:title=SyncStrategy.java}
if (SKIP_AUTO_RECOVERY) {
- return true;
+ return -1;
}
{code}
Should this be {{return 0}}?
I see a lot of design discussion in this JIRA prior, but not a lot of
consensus. What do you think is the easiest way forward from here,
[[email protected]]
> Let a replica become the leader regardless of it's last published state if
> all replicas participate in the election process.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-7065
> URL: https://issues.apache.org/jira/browse/SOLR-7065
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-7065.patch, SOLR-7065.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
