[
https://issues.apache.org/jira/browse/SOLR-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343813#comment-15343813
]
Jan Høydahl commented on SOLR-9237:
-----------------------------------
Sure, however it makes the initialization a bit more explicit and enables
inline construction with {{new}} - sounds like [~covolution]'s custom code
would benefit, so I'm OK with that..
> DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter can't be
> overidden
> -------------------------------------------------------------------------------
>
> Key: SOLR-9237
> URL: https://issues.apache.org/jira/browse/SOLR-9237
> Project: Solr
> Issue Type: Bug
> Components: highlighter
> Affects Versions: 6.1
> Reporter: Gethin James
> Assignee: Jan Høydahl
> Fix For: 6.1.1, 6.2, master (7.0)
>
> Attachments: SOLR-9237.patch
>
>
> With *6.1.0* the *protected* method
> DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter passes in a
> *private* class called FvhContainer which makes it very difficult to extend.
> I have code that extends DefaultSolrHighlighter which I can't fix due to this
> issue.
> Could you consider making FvhContainer "protected" and use a constructor?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
