[
https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-7374:
--------------------------------
Attachment: SOLR-7374.patch
Hi Hrishikesh ,
I took your latest patch and made a few minor changes. I'll list them out as
accurately as I can ( I closed the window where I was noted down the changes
while making them )
1. In {{BackupRepository}} removed some modifiers that were not needed.
2. Created {{BackupRestoreUtils}} for some of the tests to reuse the classes.
Methods like {{indexDocs}} and {{verifyDocs]} were moved there and made to
reuse in our all backup/restore tests
3. Made some modifications to the CHANGES entry
4. Merged the replication handler and core admin handler test in
{{TestHdfsBackupRestoreCore}} to one. We test it randomly
I've run the test suite once and it passes along with precommit. Let me know if
this looks good . I plan to go over it one more time tomorrow morning and
commit it otherwise
> Backup/Restore should provide a param for specifying the directory
> implementation it should use
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-7374
> URL: https://issues.apache.org/jira/browse/SOLR-7374
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Assignee: Mark Miller
> Fix For: 6.2
>
> Attachments: SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch,
> SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch,
> SOLR-7374.patch, SOLR-7374.patch
>
>
> Currently when we create a backup we use SimpleFSDirectory to write the
> backup indexes. Similarly during a restore we open the index using
> FSDirectory.open .
> We should provide a param called {{directoryImpl}} or {{type}} which will be
> used to specify the Directory implementation to backup the index.
> Likewise during a restore you would need to specify the directory impl which
> was used during backup so that the index can be opened correctly.
> This param will address the problem that currently if a user is running Solr
> on HDFS there is no way to use the backup/restore functionality as the
> directory is hardcoded.
> With this one could be running Solr on a local FS but backup the index on
> HDFS etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
