[
https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344893#comment-15344893
]
Mark Miller commented on SOLR-7374:
-----------------------------------
bq. So developers end up diagnosing and fixing such issues after committing the
code
This is a common issue, and usually it comes down to what the developers judge
at commit. There is so much random testing going on, if we did it all in one
run, the test run would take forever. At the same time, you want common paths
to be fairly well tested every run.
At the end of the day, I generally do it based on how painful it is in extra
test time vs how core the functionality being tested is.
If you are writing or changing tests, you generally run them many times before
committing (at least you probably should in many cases - there is a beasting
target and scripts to help with this), and you will find most things. The many
Jenkins machines that are running tests all the time will find them otherwise,
and that is okay too.
We have a fairly lax commit then review policy and following up with a fix or
two based on jenkins random fails is common.
I'll leave this one for you and Varun to figure out, just giving some context.
> Backup/Restore should provide a param for specifying the directory
> implementation it should use
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-7374
> URL: https://issues.apache.org/jira/browse/SOLR-7374
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Assignee: Mark Miller
> Fix For: 6.2
>
> Attachments: SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch,
> SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch,
> SOLR-7374.patch, SOLR-7374.patch
>
>
> Currently when we create a backup we use SimpleFSDirectory to write the
> backup indexes. Similarly during a restore we open the index using
> FSDirectory.open .
> We should provide a param called {{directoryImpl}} or {{type}} which will be
> used to specify the Directory implementation to backup the index.
> Likewise during a restore you would need to specify the directory impl which
> was used during backup so that the index can be opened correctly.
> This param will address the problem that currently if a user is running Solr
> on HDFS there is no way to use the backup/restore functionality as the
> directory is hardcoded.
> With this one could be running Solr on a local FS but backup the index on
> HDFS etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
