[
https://issues.apache.org/jira/browse/SOLR-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346622#comment-15346622
]
Jan Høydahl commented on SOLR-9194:
-----------------------------------
Got the patch applied. Here are some comments:
(x) When mis-typing, such as omitting the {{-z}}, we print the error msg
followed by the full usage. Suggest we instead print the helpful error message
followed by {{Type bin/solr zk -help for usage help}}
(/) There's a debug print that should probably go away? {{run_tool cp -src
build.xml -dst zk:/ -zkHost localhost:9983 -recurse false}} (bin/solr line 1001)
(/) Tested cp both ways and zk->zk, recursive error msg and and with and
without trailing slask (/)
(/) Tested rm on both file and folder
(/) Tested with ZK_HOST set in solr.in.sh
(/) Tested mv of znode
(x) This log msg from {{CloudSolrClient}} is annoying: {{INFO - 2016-06-23
16:22:05.124; org.apache.solr.client.solrj.impl.CloudSolrClient; Final
constructed zkHost string: localhost:9983}}, and it is followed by a blank
line..
(/) Tested upconfig
(x) Typo: _Name of the configset in Zookeeper that will be the *destinatino*
of_...
(x) The command {{bin/solr zk rm -r /}} succeeds, rendering Solr useless :-)
Should we simply thow an error instead?
Why do we write "_Solr MUST be started once to initialize Zookeeper before
using these commands_"? Cannot this script put e.g. {{security.json}} in the
chroot even if Solr is not yet started?
Could we wish for a {{solr zk ls}} command? But that should ba a follow-on
ticket.
> Enhance the bin/solr script to put and get arbitrary files to/from Zookeeper
> ----------------------------------------------------------------------------
>
> Key: SOLR-9194
> URL: https://issues.apache.org/jira/browse/SOLR-9194
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-9194.patch, SOLR-9194.patch
>
>
> There are a few other files that can reasonably be pushed to Zookeeper, e.g.
> solr.xml, security.json, clusterprops.json. Who knows? Even
> <collection>/state.json for the brave.
> This could reduce further the need for bouncing out to zkcli.
> Assigning to myself just so I don't lose track, but I would _love_ it if
> someone else wanted to take it...
> I'm thinking the commands would be
> bin/solr zk -putfile -z <ensemble> -p <zookeeper path> -f <local file path>
> bin/solr zk -getfile -z <ensemble> -p <zookeeper path> -f <local file path>
> but I'm not wedded to those, all suggestions welcome.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
