[ 
https://issues.apache.org/jira/browse/SOLR-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348890#comment-15348890
 ] 

Tomás Fernández Löbbe commented on SOLR-9244:
---------------------------------------------

[~gary.lee], SolrRequestInfo.clearRequestInfo() is being called on 
{{HttpSolrCall.destroy()}}, which looks like the correct place to me. See 
{{SolrDispatchFilter}}
{code:java}
      try {
        Action result = call.call();
        switch (result) {
          case PASSTHROUGH:
            chain.doFilter(request, response);
            break;
          case RETRY:
            doFilter(request, response, chain, true);
            break;
          case FORWARD:
            request.getRequestDispatcher(call.getPath()).forward(request, 
response);
            break;
        }
      } finally {
        call.destroy();
        ExecutorUtil.setServerThreadFlag(null);
      }
{code}
Is the stack trace you see the same as what was pasted in SOLR-8657? If not, 
can you provide one?

> Lots of "Previous SolrRequestInfo was not closed" in Solr log
> -------------------------------------------------------------
>
>                 Key: SOLR-9244
>                 URL: https://issues.apache.org/jira/browse/SOLR-9244
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 5.3.1
>            Reporter: Gary Lee
>            Priority: Minor
>             Fix For: 5.3.1
>
>
> After upgrading to Solr 5.3.1, we started seeing a lot of "Previous 
> SolrRequestInfo was not closed" ERROR level messages in the logs. Upon 
> further inspection, it appears this is a sanity check and not an error that 
> needs attention. It appears that the SolrRequestInfo isn't freed in one 
> particular path (no corresponding call to SolrRequestInfo.clearRequestInfo in 
> HttpSolrCall.call), which often leads to a lot of these messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to