[
https://issues.apache.org/jira/browse/LUCENE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356311#comment-15356311
]
David Smiley commented on LUCENE-7340:
--------------------------------------
I think it's dangerous that MemoryIndex.toString() can potentially generate a
massive string. The functionality is useful but specifically overriding
toString() is bad (IMO). If LUCENE-7361 results in a utility in misc/ then
this code can simply be removed resulting in a default toString() since someone
can simply use the proposed utility there to get this feature. If it results
in nothing then this code can move to a new different method like toStringDebug
that takes an Appendable (FYI StringBuilder & Writer implement that).
> MemoryIndex.toString is broken if you enable payloads
> -----------------------------------------------------
>
> Key: LUCENE-7340
> URL: https://issues.apache.org/jira/browse/LUCENE-7340
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/highlighter
> Affects Versions: 5.4.1, 6.0.1, master (7.0)
> Reporter: Daniel Collins
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-7340.diff, LUCENE-7340.diff, LUCENE-7340.patch
>
>
> Noticed this as we use Luwak which creates a MemoryIndex(true, true) storing
> both offsets and payloads (though in reality we never put any payloads in it).
> We used to use MemoryIndex.toString() for debugging and noticed it broke in
> Lucene 5.x and beyond. I think LUCENE-6155 broke it when it added support
> for payloads?
> Creating default memoryindex (as all the tests currently do) works fine, as
> does one with just offsets, it is just the payload version which is broken.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
