[
https://issues.apache.org/jira/browse/SOLR-9277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362444#comment-15362444
]
Mark Miller commented on SOLR-9277:
-----------------------------------
It should be fine to keep them all. 3 are related to autoAddReplica and will
have no effect. One is related to recovery. We might want to set that one to
the real default (minutes) and let certain tests lower it, but either way, it
should be fine.
> Clean up some more remnants of supporting old and new style solr.xml in tests
> -----------------------------------------------------------------------------
>
> Key: SOLR-9277
> URL: https://issues.apache.org/jira/browse/SOLR-9277
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> I have reason to look at the tests and I'm seeing a few remnants of old/new
> style Solr.xml support (with and without <cores>). So far:
> > SolrTestCaseJ4.copySolrHomeToTemp with a flag whether old or new style.
> > solr-no-core.xml in test files. Mostly this is identical to solr.xml, here
> > are the differences:
> in solr-no-core.xml but not solr.xml
> <int
> name="autoReplicaFailoverWaitAfterExpiration">${autoReplicaFailoverWaitAfterExpiration:10000}</int>
> <int
> name="autoReplicaFailoverWorkLoopDelay">${autoReplicaFailoverWorkLoopDelay:10000}</int>
> <int
> name="autoReplicaFailoverBadNodeExpiration">${autoReplicaFailoverBadNodeExpiration:60000}</int>
> in solr.xml but not in solr-no-cores.xml:
> <int name="leaderVoteWait">${leaderVoteWait:10000}</int>
> The question here is whether putting the three properties in
> solr-no-cores.xml would mess up tests using solr.xml and whether
> leaderVoteWait being in solr.xml would mess up tests using solr-no-cores.xml.
> I'll make a quick hack at this to see and we can discuss.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
