[
https://issues.apache.org/jira/browse/LUCENE-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364734#comment-15364734
]
David Smiley commented on LUCENE-7355:
--------------------------------------
Those changes look good Adrien.
The patch grew by a lot; it appears you accidentally included other WIP in
various places (benchmark module, some ivy files, ...)
Looking at Analyzer.normalize()...
* Why create a StringTokenStream; isn't KeywordTokenizer fine? Oh I see that's
in another module... kinda seems like a generic utility that should be in core
to me IMO.
* An easy optimization is to check if initReaderForNormalization returns the
input StringReader. If so, simply set filteredText to text.
* It's a shame to call createComponents just to get the AttributeFactory.
Perhaps some future TODO issue could be to add a createAttributeFactory method
used here and by createComponents' impls? But then if some AnalyzerWrapper is
in play then it's perhaps very cheap.
I suppose a separate issue might be for Solr to do this when someone configures
a custom Analyzer.
No blockers really; just feedback/questions.
> Leverage MultiTermAwareComponent in query parsers
> -------------------------------------------------
>
> Key: LUCENE-7355
> URL: https://issues.apache.org/jira/browse/LUCENE-7355
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7355.patch, LUCENE-7355.patch, LUCENE-7355.patch,
> LUCENE-7355.patch, LUCENE-7355.patch
>
>
> MultiTermAwareComponent is designed to make it possible to do the right thing
> in query parsers when in comes to analysis of multi-term queries. However,
> since query parsers just take an analyzer and since analyzers do not
> propagate the information about what to do for multi-term analysis, query
> parsers cannot do the right thing out of the box.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
