Github user dsmiley commented on the pull request:
https://github.com/apache/lucene-solr/commit/218b986ca0fa395b67817c858b6020160c8b5a7b#commitcomment-18151959
I like this much better Doug. I suggest aligning this new class a bit
closer to `MultiBoolValues` since it's actually very similar except that it has
exactly 2 ValueSources it operates on, not variable. Perhaps name
"BiBoolValues" with the same rationale as why the JDK has BiPredicate as
opposed to just Predicate? Along with the class name change the other is to
change the abstract method from `compare(double,double)` to `protected abstract
boolean func(int doc, FunctionValues lhs, FunctionValues rhs);`
-- same method name as MultiBoolValues, and note it takes FunctionValues
thus allowing a subclass to perhaps pick the long value or some other if it
wants.
Also, equals & hashcode may need to be updated now? Equals should be true
if both instances have the same class (class.equals) and lhs & rhs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
