[
https://issues.apache.org/jira/browse/LUCENE-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368202#comment-15368202
]
Christine Poerschke commented on LUCENE-7372:
---------------------------------------------
Thanks [~jpountz] for the quick review! Added extra constructor
{code}
protected FilterWeight(Weight weight) {
super(weight.getQuery());
this.in = weight;
}
{code}
as you suggested. It seems though that the {{FilterWeight(Query query, Weight
weight)}} constructor variant is still needed to cater for
[BlockJoinWeight|https://github.com/apache/lucene-solr/blob/master/lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java#L119]
and
[ToChildBlockJoinWeight|https://github.com/apache/lucene-solr/blob/master/lucene/join/src/java/org/apache/lucene/search/join/ToChildBlockJoinQuery.java#L85]
usage?
> factor out a org.apache.lucene.search.DelegatingWeight class
> ------------------------------------------------------------
>
> Key: LUCENE-7372
> URL: https://issues.apache.org/jira/browse/LUCENE-7372
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7372.patch, LUCENE-7372.patch
>
>
> * {{DelegatingWeight}} to delegate method implementations to the {{Weight}}
> that it wraps
> * exception: no delegating for the {{bulkScorer}} method implementation since
> currently not all delegating weights implement/override that default method
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
