[
https://issues.apache.org/jira/browse/SOLR-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368288#comment-15368288
]
ASF GitHub Bot commented on SOLR-9280:
--------------------------------------
GitHub user kelaban opened a pull request:
https://github.com/apache/lucene-solr/pull/50
SOLR-9280 - make nodeName a configurable parameter in solr.xml
This patch makes live nodeName configurable via solr.xml by setting
```xml
<solr>
<solrcloud>
<str name="nodeName">${solr.nodeName:}</str>
</solrcloud>
</solr>
```
To test, I randomly set nodeName in `AbstractFullDistribZkTestBase` for
complete coverage.
I've gotten all tests to pass both when ALWAYS using a random nodeName and
with it being set randomly. However during one particular run I got a test
failure for the following:
`ant test -Dtestcase=TestReqParamsAPI -Dtests.method=test
-Dtests.seed=391BC4715DE8C2FE -Dtests.slow=true -Dtests.locale=pl-PL
-Dtests.timezone=Asia/Chungking -Dtests.asserts=true
-Dtests.file.encoding=UTF-8` but am unable to reproduce the issue in eclipse
and at this time am not sure if its related
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelaban/lucene-solr jira/master/SOLR-9280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit b1de1f9ef97a5957747f7fcb9ac9e7ce4acfac84
Author: Keith Laban <[email protected]>
Date: 2016-06-30T15:12:16Z
SOLR-9280 - make nodeName a configurable parameter in solr.xml
----
> make nodeName a configurable parameter in solr.xml
> --------------------------------------------------
>
> Key: SOLR-9280
> URL: https://issues.apache.org/jira/browse/SOLR-9280
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Keith Laban
>
> Originally node name is automatically generated based on
> {{<host>:<port>_<context>}}. Instead it should be configurable in solr.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
