[
https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372249#comment-15372249
]
Steve Rowe commented on LUCENE-7012:
------------------------------------
[~thetaphi], you wrote on this issue:
bq. As said in other issue, I will take care of that. We already have License
checks, I will just add a position check for *.java files to the groovy script
(it is a one-liner).
I just posted a (larger than one-liner) patch to do this to LUCENE-7013, but I
don't see any comment from you about taking care of it there? Are you talking
about some other issue? In any case, would you please review the patch, and
hopefully reduce its size if that's possible?
> Change Lucene/Solr IDE configs to place new Java files' license header before
> the package declaration
> -----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-7012
> URL: https://issues.apache.org/jira/browse/LUCENE-7012
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Shai Erera
> Fix For: 5.5, 6.0
>
> Attachments: LUCENE-7012-intellij.patch, LUCENE-7012.patch
>
>
> Today the license header is placed after the package declaration. This
> results in inconsistency in our files. In some the license is put after the
> package and before the imports, in others it appears after the imports but
> before class declaration and in others it appears in the middle of the
> imports.
> Also, when you e.g. "Organize Imports" in eclipse, if the header is located
> in the middle of imports, it's sometimes completely removed from the file.
> This issue is about changing the "New Java Files" template in eclipse so that
> the license header is placed before the package declaration. This ensures
> that "Organize Imports" doesn't mess with it, as well for new files (created
> in eclipse), we will start getting some consistency.
> If we also want to handle all current files by moving the license header
> before the package, we can do so (I volunteer), but since it's a big change,
> will likely do it over multiple commits and no need for an issue. BTW, if
> anyone knows of a tool that can automate that, great. I found that Apache has
> a perl script but it seems to only fix the header to the new format, yet not
> moving it in the file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
