[
https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374983#comment-15374983
]
Steve Rowe commented on LUCENE-7013:
------------------------------------
+1 for your changes [~thetaphi], thanks!
It finds 86 violations for me now too, after I pulled master.
One style question: why not return the result of {{.any}} rather than using
if/else?:
{code:java}
if (lineSplitter.split(matcher.group(1)).any{
licenseMatcher.match(ratDocument, it) }) {
return true;
}
return false;
{code}
Versus the less verbose
{code:java}
return lineSplitter.split(matcher.group(1)).any{
licenseMatcher.match(ratDocument, it) };
{code}
> Move license header before package declaration in all *.java files
> ------------------------------------------------------------------
>
> Key: LUCENE-7013
> URL: https://issues.apache.org/jira/browse/LUCENE-7013
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 5.5, trunk
>
> Attachments: LUCENE-7013-precommit.patch,
> LUCENE-7013-precommit.patch, LUCENE-7013.patch, mvcopyright.py, mvcopyright.py
>
>
> In LUCENE-7012 we committed a change to the IDE templates to place the
> license header before the package declaration in new Java files.
> I wrote a simple Python script which moves the header before the package
> declaration. To be on the safe side, if a .java file does not already start
> with the license header or with {{package org.apache}}, it doesn't modify it
> and asks for manual intervention.
> It runs quite fast, so I don't mind running and committing one module at a
> time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
