[
https://issues.apache.org/jira/browse/SOLR-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375738#comment-15375738
]
Steve Rowe commented on SOLR-9306:
----------------------------------
bq. Is it okay to add the proof-of-concept test or would it be preferable to
(in the end) only commit the build and pom xml changes?
I think the POC test is fine.
bq. Would it make sense to add the test-jar goal for all of lucene/analysis/*
to be consistent with ant or should goals only be added as and when needed?
I think we should only add test-jar where needed.
> give solr/contrib/analysis-extras's test classes access to lucene/analysis's
> test classes
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-9306
> URL: https://issues.apache.org/jira/browse/SOLR-9306
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9306.patch
>
>
> patch summary:
> added proof-of-concept test:
> * made ICUCollationField's private {{createFromRules}} static with package
> visibility
> * added createFromRules test to {{TestICUCollationField}} (which sometimes
> uses {{lucene/analysis/util}}'s {{StringMockResourceLoader}} class)
> build xml files (ant):
> * added -compile-test-lucene-analysis dependency to compile-test target in
> solr/contrib/analysis-extras
> * defined -compile-test-lucene-analysis target in solr/common-build.xml
> pom xml templates (maven):
> * added test-jar goal to pom.xml.template in lucene/analysis/common
> * added lucene-analyzers-common dependency to pom.xml.template in
> solr/contrib/analysis-extras
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
