[ 
https://issues.apache.org/jira/browse/SOLR-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378733#comment-15378733
 ] 

Jamie Swain commented on SOLR-7036:
-----------------------------------

[~mdvir1] that just won't apply for some reason. 

I wget this file:
{code}wget 
https://issues.apache.org/jira/secure/attachment/12817769/SOLR-7036.patch{code}

Then try to apply the patch, according to 
https://wiki.apache.org/solr/HowToContribute

{code}
tuna:lucene-solr ((f9c9470...) $%)$ patch -p1 -i SOLR-7036.patch --dry-run
patching file solr/core/src/java/org/apache/solr/request/SimpleFacets.java
Hunk #2 FAILED at 444.
Hunk #3 FAILED at 497.
Hunk #4 FAILED at 533.
Hunk #5 FAILED at 577.
4 out of 5 hunks FAILED -- saving rejects to file 
solr/core/src/java/org/apache/solr/request/SimpleFacets.java.rej
patching file solr/core/src/java/org/apache/solr/search/facet/FacetField.java
patching file solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
patching file 
solr/core/src/java/org/apache/solr/search/facet/UnInvertedField.java
Hunk #5 FAILED at 178.
Hunk #6 FAILED at 408.
2 out of 7 hunks FAILED -- saving rejects to file 
solr/core/src/java/org/apache/solr/search/facet/UnInvertedField.java.rej
patching file 
solr/core/src/java/org/apache/solr/search/facet/UninvertedFieldOrdsOnly.java
patching file solr/core/src/test/org/apache/solr/TestGroupingSearch.java
patching file solr/core/src/test/org/apache/solr/request/SimpleFacetsTest.java
Hunk #1 FAILED at 372.
Hunk #2 FAILED at 418.
Hunk #3 FAILED at 438.
Hunk #4 FAILED at 460.
4 out of 4 hunks FAILED -- saving rejects to file 
solr/core/src/test/org/apache/solr/request/SimpleFacetsTest.java.rej
patching file solr/solrj/src/java/org/apache/solr/common/params/FacetParams.java
tuna:lucene-solr ((f9c9470...) $%)$ 

{code}

I'm happy to help in any way I can.  Would like like to send me a dropbox link 
to a zip of your lucene-solr source directory?  I can get an applyable patch 
ready and send it back to you to post here?

> Faster method for group.facet
> -----------------------------
>
>                 Key: SOLR-7036
>                 URL: https://issues.apache.org/jira/browse/SOLR-7036
>             Project: Solr
>          Issue Type: Improvement
>          Components: faceting
>    Affects Versions: 4.10.3
>            Reporter: Jim Musil
>            Assignee: Erick Erickson
>             Fix For: 5.5, 6.0
>
>         Attachments: SOLR-7036.patch, SOLR-7036.patch, SOLR-7036.patch, 
> SOLR-7036.patch, performance.txt
>
>
> This is a patch that speeds up the performance of requests made with 
> group.facet=true. The original code that collects and counts unique facet 
> values for each group does not use the same improved field cache methods that 
> have been added for normal faceting in recent versions.
> Specifically, this approach leverages the UninvertedField class which 
> provides a much faster way to look up docs that contain a term. I've also 
> added a simple grouping map so that when a term is found for a doc, it can 
> quickly look up the group to which it belongs.
> Group faceting was very slow for our data set and when the number of docs or 
> terms was high, the latency spiked to multiple second requests. This solution 
> provides better overall performance -- from an average of 54ms to 32ms. It 
> also dropped our slowest performing queries way down -- from 6012ms to 991ms.
> I also added a few tests.
> I added an additional parameter so that you can choose to use this method or 
> the original. Add group.facet.method=fc to use the improved method or 
> group.facet.method=original which is the default if not specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to