[ https://issues.apache.org/jira/browse/SOLR-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383138#comment-15383138 ]
Mike Drob commented on SOLR-7280: --------------------------------- {code} - public int getCoreLoadThreadCount() { - return coreLoadThreads; + public int getCoreLoadThreadCount(int def) { + return coreLoadThreads == null ? def : coreLoadThreads; } {code} It might make sense for this to look like this instead: {code} public int getCoreLoadThreadCount(boolean zkAware) { return coreLoadThreads == null ? (zkAware ? DEFAULT_CORE_LOAD_THREADS_IN_CLOUD : DEFAULT_CORE_LOAD_THREADS) : coreLoadThreads; } {code} That was the standalone v cloud logic doesn't have to leak out as much. > Load cores in sorted order and tweak coreLoadThread counts to improve cluster > stability on restarts > --------------------------------------------------------------------------------------------------- > > Key: SOLR-7280 > URL: https://issues.apache.org/jira/browse/SOLR-7280 > Project: Solr > Issue Type: Bug > Components: SolrCloud > Reporter: Shalin Shekhar Mangar > Assignee: Noble Paul > Fix For: 6.2 > > Attachments: SOLR-7280-5x.patch, SOLR-7280.patch, SOLR-7280.patch > > > In SOLR-7191, Damien mentioned that by loading solr cores in a sorted order > and tweaking some of the coreLoadThread counts, he was able to improve the > stability of a cluster with thousands of collections. We should explore some > of these changes and fold them into Solr. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org