[
https://issues.apache.org/jira/browse/LUCENE-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383476#comment-15383476
]
ASF subversion and git services commented on LUCENE-7385:
---------------------------------------------------------
Commit efef37bb6795ed3be33056025a88d2cd4b848604 in lucene-solr's branch
refs/heads/master from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efef37b ]
LUCENE-7385: Improve/fix assert messages in SpanScorer.
> SpanScorer's assert message strings should reference spans.toString()
> ---------------------------------------------------------------------
>
> Key: LUCENE-7385
> URL: https://issues.apache.org/jira/browse/LUCENE-7385
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: David Smiley
> Priority: Minor
> Attachments: LUCENE_7385.patch
>
>
> SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer
> to {{this.toString()}}. I'm pretty confident the intention was for this to
> actually be {{spans.toString()}}, not "this" which is a SpanScorer that
> doesn't even have a custom toString. It was probably correct once but after
> some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]