[
https://issues.apache.org/jira/browse/LUCENE-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384357#comment-15384357
]
Alan Woodward commented on LUCENE-7384:
---------------------------------------
When I merged Spans and SpanScorer, I needed a way of setting a docScorer
object on a Spans after it had been created - for example, if the exclusion
Spans in a SpanNotQuery is empty, then we just return the inclusion Spans, but
because the docScorer was only being set on the root Spans object you could end
up with a null scorer. Now that SpanScorer and Spans are separate again, and
SpanScorer holds the similarity objects, we don't need to deal with this any
more.
> Remove ScoringWrapperSpans
> --------------------------
>
> Key: LUCENE-7384
> URL: https://issues.apache.org/jira/browse/LUCENE-7384
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: David Smiley
> Attachments: LUCENE_7384.patch
>
>
> In LUCENE-6919 (Lucene 5.5), ScoringWrapperSpans was modified in such a way
> that made the existence of this class pointless, and possibly broke anyone
> who was using it as it's SimScorer argument isn't used anymore. We should
> now delete it. SpanWeight has getSimScorer() so people can customize the
> SimScorer that way.
> Another small change I observe to improve is have SpanWeight.buildSimWeight's
> last line use the existing Similarity that has already been populated on the
> field?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
