Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/52#discussion_r71730215
--- Diff: solr/core/src/java/org/apache/solr/core/SolrCore.java ---
@@ -414,7 +416,19 @@ private IndexDeletionPolicyWrapper
initDeletionPolicy(IndexDeletionPolicyWrapper
} else {
delPolicy = new SolrDeletionPolicy();
}
- return new IndexDeletionPolicyWrapper(delPolicy);
+
+ return new IndexDeletionPolicyWrapper(delPolicy, snapshotMgr);
+ }
+
+ private SolrSnapshotMetaDataManager initSnapshotMetaDataManager() {
--- End diff --
What do you think about possibly creating a Directory lazily on first use
of a snapshot? I'm a tad concerned we're weighing Solr down a bit more for
everyone when only a small number of installations in the future will use this.
What's your feeling @markrmiller ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
