[ https://issues.apache.org/jira/browse/SOLR-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389953#comment-15389953 ]
Joel Bernstein edited comment on SOLR-9331 at 7/22/16 6:08 PM: --------------------------------------------------------------- Also let's take close at all the adjustments done to the length in SolrIndexSearcher.getDocListNC(QueryResult qr, QueryCommand cmd). was (Author: joel.bernstein): Also let's take close at all the adjustments done to the length in getDocListNC(QueryResult qr, QueryCommand cmd). > Can we remove ReRankQuery's length constructor argument? > -------------------------------------------------------- > > Key: SOLR-9331 > URL: https://issues.apache.org/jira/browse/SOLR-9331 > Project: Solr > Issue Type: Wish > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Christine Poerschke > Priority: Minor > Attachments: SOLR-9331.patch > > > Can we remove ReRankQuery's length constructor argument? It is a > ReRankQParserPlugin private class. > proposed patch summary: > * change ReRankQuery.getTopDocsCollector to use its len argument (instead of > the length member) > * remove ReRankQuery's length member and constructor argument > * remove ReRankQParser.parse's use of the rows and start parameters > motivation: towards ReRankQParserPlugin and LTRQParserPlugin (SOLR-8542) > sharing (more) code -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org