[
https://issues.apache.org/jira/browse/LUCENE-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393061#comment-15393061
]
David Smiley commented on LUCENE-7394:
--------------------------------------
I have to wonder if the design elegance goal you're after here is worth the
price. MemoryIndex is used in cases where it needs to be cheap to use/re-use
for high-throughput. Just keep this in mind please.
> Make MemoryIndex immutable
> --------------------------
>
> Key: LUCENE-7394
> URL: https://issues.apache.org/jira/browse/LUCENE-7394
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Martijn van Groningen
>
> The MemoryIndex itself should just be a builder that constructs an
> IndexReader instance. The whole notion of freezing a memory index should be
> removed.
> While we change this we should also clean this class up. There are many
> methods to add a field, we should just have a single method that accepts a
> `IndexableField`.
> The `keywordTokenStream(...)` method is unused and untested and should be
> removed and it doesn't belong with the memory index.
> The `setSimilarity(...)`, `createSearcher(...)` and `search(...)` methods
> should be removed, because the MemoryIndex should just be responsible for
> creating an IndexReader instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
