[ 
https://issues.apache.org/jira/browse/SOLR-9310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399194#comment-15399194
 ] 

Pushkar Raste commented on SOLR-9310:
-------------------------------------

What was the original reason for adding fingerprint check.  Unless that is 
clear we are not solving the right problem here. I couldn't find a test case 
that led to adding fingerprint checl.

* If intent is to check state before node down, for clarity. check should be 
made before applying updates.
* Let's also make read and sort update log of recovering node only once.
* I would also uncomment parallel indexing logic in the 
{{PeerSyncReplicationTest}}, as this won't break fingerprint check, with your 
patch. 

> PeerSync fails on a node restart due to IndexFingerPrint mismatch
> -----------------------------------------------------------------
>
>                 Key: SOLR-9310
>                 URL: https://issues.apache.org/jira/browse/SOLR-9310
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Pushkar Raste
>            Assignee: Noble Paul
>         Attachments: SOLR-9310.patch, SOLR-9310.patch, SOLR-9310.patch
>
>
> I found that Peer Sync fails if a node restarts and documents were indexed 
> while node was down. IndexFingerPrint check fails after recovering node 
> applies updates. 
> This happens only when node restarts and not if node just misses updates due 
> reason other than it being down.
> Please check attached patch for the test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to