[ 
https://issues.apache.org/jira/browse/SOLR-9310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399217#comment-15399217
 ] 

Noble Paul edited comment on SOLR-9310 at 7/29/16 12:16 PM:
------------------------------------------------------------

bq.What was the original reason for adding fingerprint check?

Previously we were just comparing the latest versions. We had no way to know if 
some intermediate versions were missing or not. In most cases, that would be 
correct. but if there was an out of order update, then we would assume we have 
everything and go ahead with downloading versions after our latest update. 
Fingerprints compute the hash of all versions. So , we will be able to avoid 
such errors

bq.Let's also make read and sort update log of recovering node only once.
Sure. I'm aware of this optimization. It was a rudimentary patch to ensure that 
the approach is valid 


was (Author: noble.paul):
bq.What was the original reason for adding fingerprint check?

Previously we were just comparing the latest versions. We had no way to know if 
some intermediate versions were missing or not. In most cases, that would be 
correct. but if there was an out of order update, then we would assume we have 
everything and go ahead with downloading versions after our latest update. 
Fingerprints compute the hash of all versions. So , we will be able to avoid 
such errors

> PeerSync fails on a node restart due to IndexFingerPrint mismatch
> -----------------------------------------------------------------
>
>                 Key: SOLR-9310
>                 URL: https://issues.apache.org/jira/browse/SOLR-9310
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Pushkar Raste
>            Assignee: Noble Paul
>         Attachments: SOLR-9310.patch, SOLR-9310.patch, SOLR-9310.patch
>
>
> I found that Peer Sync fails if a node restarts and documents were indexed 
> while node was down. IndexFingerPrint check fails after recovering node 
> applies updates. 
> This happens only when node restarts and not if node just misses updates due 
> reason other than it being down.
> Please check attached patch for the test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to