[ 
https://issues.apache.org/jira/browse/SOLR-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406641#comment-15406641
 ] 

ASF GitHub Bot commented on SOLR-9242:
--------------------------------------

GitHub user hgadre opened a pull request:

    https://github.com/apache/lucene-solr/pull/62

    [SOLR-9242] Fix unit test failure on Windows platform.

    The root cause of the failure is the usage of URI::getPath() method in the 
backup/restore functionality (e.g. in BackupManager::downloadFromZK OR in the 
OverseerCollectionMessageHandler::processBackupAction methods). On the Windows 
platform, usage of URI.getPath() returns an invalid path string (e.g.  URI 
file:///C:/lucene-solr/solr
    returns /C:/lucene-solr/solr as the result of getPath() method).
    
    Refer to following discussion for more details,
    http://stackoverflow.com/questions/9834776/java-nio-file-path-issue
    
    Since the caller may have used this method to generate the string 
representation for the pathComponents, we implement a work-around specifically 
for Windows platform to remove the leading '/' character.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hgadre/lucene-solr SOLR-9242_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----

----


> Collection level backup/restore should provide a param for specifying the 
> repository implementation it should use
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9242
>                 URL: https://issues.apache.org/jira/browse/SOLR-9242
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hrishikesh Gadre
>            Assignee: Varun Thacker
>             Fix For: 6.2
>
>         Attachments: SOLR-9242.patch, SOLR-9242.patch, SOLR-9242.patch, 
> SOLR-9242.patch, SOLR-9242.patch, SOLR-9242_followup.patch
>
>
> SOLR-7374 provides BackupRepository interface to enable storing Solr index 
> data to a configured file-system (e.g. HDFS, local file-system etc.). This 
> JIRA is to track the work required to extend this functionality at the 
> collection level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to