[
https://issues.apache.org/jira/browse/SOLR-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409262#comment-15409262
]
Mikhail Khludnev commented on SOLR-5725:
----------------------------------------
Hello, I skim through the patch. Generally it's ok, here are some notes:
* as far the proposed method is an optimization of {{enum}}, it's reasonable to
name it starting with it, eg {{enumprobing}};
* it's preferable to avoid code diverging, instead of introducing
{{SimpleFacets.getFacetTermIntersection()}} it's better to introduce
conditional code branches (yep, this is sad) into {{getFacetTermEnumCounts()}}.
* implementation should be consistent, thus it's worth to implement the similar
idea in {{else}} branch of {{if (df >= minDfFilterCache) }}
* it should be resilient for other parameter, eg it should throw an exception
if combined with {{mincount=2}} or more
* the test case is beefy enough, but it's also necessary to include new method
into existing regression tests with amending asserts, yep. it's pain.
> Efficient facets without counts for enum method
> -----------------------------------------------
>
> Key: SOLR-5725
> URL: https://issues.apache.org/jira/browse/SOLR-5725
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Alexey Kozhemiakin
> Assignee: Shalin Shekhar Mangar
> Fix For: 6.0
>
> Attachments: SOLR-5725-5x.patch, SOLR-5725.patch
>
>
> Shot version:
> This improves performance for facet.method=enum when it's enough to know that
> facet count>0, for example when you it's when you dynamically populate
> filters on search form. New method checks if two bitsets intersect instead of
> counting intersection size.
> Long version:
> We have a dataset containing hundreds of millions of records, we facet by
> dozens of fields with many of facet-excludes and have relatively small number
> of unique values in fields, around thousands.
> Before executing search, users work with "advanced search" form, our goal is
> to populate dozens of filters with values which are applicable with other
> selected values, so basically this is a use case for facets with mincount=1,
> but without need in actual counts.
> Our performance tests showed that facet.method=enum works much better than
> fc\fcs, probably due to a specific ratio of "docset"\"unique terms count".
> For example average execution of query time with method fc=1500ms, fcs=2600ms
> and with enum=280ms. Profiling indicated the majority time for enum was spent
> on intersecting docsets.
> Hers's a patch that introduces an extension to facet calculation for
> method=enum. Basically it uses docSetA.intersects(docSetB) instead of
> docSetA. intersectionSize (docSetB).
> As a result we were able to reduce our average query time from 280ms to 60ms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
