[ 
https://issues.apache.org/jira/browse/SOLR-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413069#comment-15413069
 ] 

Noble Paul commented on SOLR-9320:
----------------------------------

Thanks [~varunthacker]
bq.CollectionAdminRequest#DeleteNode and ReplaceNode - Can we add a little bit 
of Javadocs explaining what the parameters are?

sure.

bq.Any reason why we needed to change modify 
AsyncCollectionAdminRequest#setAsyncId ?

Yeah. Keeping that abstract was bad. That is deprecated

bq.In OverseerCollectionMessageHandler#addReplica can't we make node and 
coreName final to start with?

No, they are modified in between

bq.The logging in this patch needs to be improved. It's too verbose and 
redundant.


Logging is screwed up. I added them for my testing. I shall clean them up.


> A REPLACENODE command to decommission an existing node with another new node
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-9320
>                 URL: https://issues.apache.org/jira/browse/SOLR-9320
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: Noble Paul
>         Attachments: DELETENODE.jpeg, REPLACENODE_After.jpeg, 
> REPLACENODE_Before.jpeg, REPLACENODE_call_response.jpeg, SOLR-9320.patch, 
> SOLR-9320.patch, SOLR-9320.patch, SOLR-9320.patch, SOLR-9320.patch, 
> SOLR-9320.patch, SOLR-9320.patch
>
>
> The command should accept a source node and target node. recreate the 
> replicas in source node in the target and do a DLETENODE of source node



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to