GitHub user susheelks opened a pull request:

    https://github.com/apache/lucene-solr/pull/69

    SOLR-9399: Delete requests do not send credentials & fails for Basic 
Authentication

    This is a bug fix to set Authentication credential in case of delete 
requests.  
    
    There is a duplicate code between update & delete requests which most 
likely has caused this issue and left to set credentials in case of delete 
requests.  I'll create a separate jira to refactor the code and also tests for 
authentication seems to be broken. 
    
    The test class BasicAuthIntegrationTest doesn't have any test methods 
except the protected method doExtraTests which doesn't seems to be called from 
anywhere and delete tests needs to be added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/susheelks/lucene-solr SOLR-9399

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit 7c68a42728531775240c7b6ff2bad5a23dfdb255
Author: Kumar, Susheel (CORP) <[email protected]>
Date:   2016-08-11T00:57:49Z

    Added call to setBasicAuthCredentials for delete request

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to