[
https://issues.apache.org/jira/browse/SOLR-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420073#comment-15420073
]
Yonik Seeley commented on SOLR-9326:
------------------------------------
Mostly reviewing this from the perspective of public API and changes to
existing code, and it looks good to me!
super minor: the use of public API constants in the tests mean that one can
change one of them and still have everything work. I often tend to use
literals in tests, and I've seen others assert the constants are the expected
literal.
> Ability to create/delete/list snapshots for a solr collection
> -------------------------------------------------------------
>
> Key: SOLR-9326
> URL: https://issues.apache.org/jira/browse/SOLR-9326
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Hrishikesh Gadre
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
