[ 
https://issues.apache.org/jira/browse/SOLR-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-9405:
-------------------------------
    Attachment: SOLR_9405_no_compute.patch

Not sure if it's related to this issue, but when I beast test 
TestCollectionStateWatchers, I get "ZkTestServer Watch limit violations".
{{ant beast -Dtestcase=TestCollectionStateWatchers -Dbeast.iters=100}}  It only 
took a few minutes.

Separately from that, I find the use of {{ConcurrentHashMap.compute()}} in this 
class very odd... definitely not the intended purpose of this method -- even 
the return value isn't used.  I think it's a nifty method/feature, it's just 
that I don't see why ZkTestServer is calling it the way it's calling it versus 
simply calling {{get()}}.  Attached is a patch showing something simpler.  My 
beast test failed _with and without_ this patch.

> ConcurrentModificationException in ZkStateReader.getStateWatchers
> -----------------------------------------------------------------
>
>                 Key: SOLR-9405
>                 URL: https://issues.apache.org/jira/browse/SOLR-9405
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: 6.1
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 6.2, master (7.0)
>
>         Attachments: SOLR-9405.patch, SOLR-9405.patch, 
> SOLR_9405_no_compute.patch
>
>
> Jenkins found this: http://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Linux/1432/
> {code}
> Stack Trace:
> java.util.ConcurrentModificationException
>         at 
> __randomizedtesting.SeedInfo.seed([FA459DF725097EFF:A77E52876204E1C1]:0)
>         at 
> java.util.HashMap$HashIterator.nextNode(java.base@9-ea/HashMap.java:1489)
>         at 
> java.util.HashMap$KeyIterator.next(java.base@9-ea/HashMap.java:1513)
>         at 
> java.util.AbstractCollection.addAll(java.base@9-ea/AbstractCollection.java:351)
>         at java.util.HashSet.<init>(java.base@9-ea/HashSet.java:119)
>         at 
> org.apache.solr.common.cloud.ZkStateReader.getStateWatchers(ZkStateReader.java:1279)
>         at 
> org.apache.solr.common.cloud.TestCollectionStateWatchers.testSimpleCollectionWatch(TestCollectionStateWatchers.java:116)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to