[
https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430744#comment-15430744
]
Varun Thacker commented on SOLR-6246:
-------------------------------------
bq. close the writer after build. In analyzing the method usages
I think that might be a good solution.
Solr does not support real time updates to the suggester so its fine from it's
perspective.
>From a Lucene API standpoint it's probably not ideal but maybe not all that
>bad?
This is what I am thinking -
Create a Lucene issue in which {{AnalyzingInfixSuggester#build}} closes the
writer by default at the end.
The {{add}} and {{update}} methods call {{ensureOpen}} and those who do
frequent real time updates directly via lucene won't see any slowdowns.
[~mikemccand] - Would this approach have any major drawback from Lucene's
perspective? Else I can go ahead an tackle this in a Lucene issue
> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
> Key: SOLR-6246
> URL: https://issues.apache.org/jira/browse/SOLR-6246
> Project: Solr
> Issue Type: Sub-task
> Components: SearchComponents - other
> Affects Versions: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
> Reporter: Varun Thacker
> Attachments: SOLR-6246-test.patch, SOLR-6246-test.patch,
> SOLR-6246.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to
> AnalyzingInfixSuggester. One of the changes that went in was a writer is
> persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester
> is created. When trying to create a new writer on the same Directory a lock
> cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should
> pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a
> reloadHook where we close the writer?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
