[
https://issues.apache.org/jira/browse/SOLR-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432957#comment-15432957
]
Shalin Shekhar Mangar commented on SOLR-9360:
---------------------------------------------
According to the description -- the current script prevents starting a solr on
port 10500 if another solr on 10504 is running. Why would that happen? are we
not matching whole words?
I think a better fix would be to match the full -Djetty.port=$SOLR_PORT string.
Many OS do not have netstat by default e.g. centos minimal. Docker-solr which
uses a stripped down version of debian also does not have netstat by default.
Also, the -p switch used in the patch is not supported on MacOS. (thanks to
[~makuk66] for these tips).
> Solr script not properly checking SOLR_PID
> ------------------------------------------
>
> Key: SOLR-9360
> URL: https://issues.apache.org/jira/browse/SOLR-9360
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Affects Versions: 6.1
> Reporter: Alessandro Benedetti
> Assignee: Erick Erickson
> Attachments: SOLR_9360.patch
>
>
> In the solr script we see in 3-4 areas this check :
> SOLR_PID=`ps auxww | grep start\.jar | grep -w $SOLR_PORT | grep -v grep |
> awk '{print $2}' | sort -r`
> This can potentially prevent a solr instance to start in the case another
> process by any chance contains the port int the command itself ( not
> necessarily actually using the port) .
> e.g.
> java -server -Djetty.port=10504 -DSTOP.PORT=9504 -DSTOP.KEY=solrrocks
> -DMASTER_CORE_URL=external-server:10500/solr -jar start.jar --module=http
> A solr is running on 10504.
> A new Solr will not be able to start on 10500 ( but actually the port is
> free).
> This should be replaced by a real check if the port is used ( like netstat or
> similar) .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
