[
https://issues.apache.org/jira/browse/SOLR-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438466#comment-15438466
]
Michael Sun commented on SOLR-9284:
-----------------------------------
bq. Can you take a look and see if the prior version was more correct?
For the name map (BlockDirectoryCache.names) mentioned in my previous comments,
it's currently ConcurrentHashMap, not ConcurrentLinkedHashMap.
ConcurrentHashMap doesn't evict items implicitly. Therefore there was no need
to setup eviction listener and prior version is ok.
The patch changes the name map from ConcurrentHashMap to Caffeine which can
evict items implicitly. Therefore it's necessary to setup a removal listener.
Or keep ConcurrentHashMap since the name map usually doesn't grow much from
test results.
[~ben.manes] I guess you are talking about the BlockCache.cache, which was
using ConcurrentLinkedHashMap, and now Caffeine. There is a removal listener
setup in the code and it looks ok. Feel free to open a JIRA if you have any
specific concern about it.
> The HDFS BlockDirectoryCache should not let it's keysToRelease or names maps
> grow indefinitely.
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-9284
> URL: https://issues.apache.org/jira/browse/SOLR-9284
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: hdfs
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9284.patch, SOLR-9284.patch
>
>
> https://issues.apache.org/jira/browse/SOLR-9284
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
