[ 
https://issues.apache.org/jira/browse/LUCENE-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022186#comment-13022186
 ] 

Simon Willnauer commented on LUCENE-3018:
-----------------------------------------

bq. I included the library directory in the ant task itself.
Awesome that is great.

here are some comments:

* can you make sure you include the version name of cpptasks in the jar file 
just like Steven proposed above? something like cpptasks-1.0b5.jar, depending 
on from what sources you build it and reattach it to the issue?

* can you please replace all tabs with spaces in the patch and make sure the 
alignment is ok

* I think we should name the task build-native-unix so we can add a 
build-native-windows later.

overall we are very close, good work!

simon

> Lucene Native Directory implementation need automated build
> -----------------------------------------------------------
>
>                 Key: LUCENE-3018
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3018
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Build
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Varun Thacker
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3018.patch, LUCENE-3018.patch, LUCENE-3018.patch, 
> LUCENE-3018.patch, cpptasks-LICENSE-ASL.txt, cpptasks.jar, cpptasks.jar
>
>
> Currently the native directory impl in contrib/misc require manual action to 
> compile the c code (partially) documented in 
>  
> https://svn.apache.org/repos/asf/lucene/dev/trunk/lucene/contrib/misc/src/java/overview.html
> yet it would be nice if we had an ant task and documentation for all 
> platforms how to compile them and set up the prerequisites.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to