[ https://issues.apache.org/jira/browse/SOLR-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447712#comment-15447712 ]
David Smiley commented on SOLR-9447: ------------------------------------ +1. Say why was it cloning it twice? > Do not clone SolrInputDocument if update processor chain does not contain > custom processors > ------------------------------------------------------------------------------------------- > > Key: SOLR-9447 > URL: https://issues.apache.org/jira/browse/SOLR-9447 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud > Reporter: Shalin Shekhar Mangar > Assignee: Shalin Shekhar Mangar > Fix For: master (7.0), 6.3 > > Attachments: SOLR-9447.patch > > > In SOLR-3215 we started cloning documents before adding them locally and send > the cloned copy to replicas. This was done because processors after > DistributedUpdateProcessor can affect the docs before they are sent to the > replicas. > However, we can avoid the deep copy if we know for sure that the processors > after DUP are one of (LogUpdateProcessor, RunUpdateProcessor, > TolerantUpdateProcessor) which definitely do not modify the document. This > ensures that the common case is optimized. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org