[ 
https://issues.apache.org/jira/browse/LUCENE-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459221#comment-15459221
 ] 

Tim Allison edited comment on LUCENE-7434 at 9/2/16 6:44 PM:
-------------------------------------------------------------

bq. I  think that is too strict when more than the required number of subSpans 
are actually present in the segment.

Y, you're right, of course.  Argh.

{code}
  public void testMinShouldMatch5() throws Exception {
    //    "x l x m x n x o x"
    SpanNearQuery q = new SpanNearQuery(new SpanQuery[]{
        new SpanTermQuery(new Term(FIELD, "l")), new SpanTermQuery(new 
Term(FIELD, "m")), new SpanTermQuery(new Term(FIELD, "o"))
    }, 3, true, 2);
    Spans spans = q.createWeight(searcher, false, 
1f).getSpans(searcher.getIndexReader().leaves().get(0), 
SpanWeight.Postings.POSITIONS);
    assertFinished(spans);//but there should be a match!
  }
{code}


was (Author: talli...@mitre.org):
bq. I  think that is too strict when more than the required number of subSpans 
are actually present in the segment.

Y, you're right.  Argh.

{code}
  public void testMinShouldMatch5() throws Exception {
    //    "x l x m x n x o x"
    SpanNearQuery q = new SpanNearQuery(new SpanQuery[]{
        new SpanTermQuery(new Term(FIELD, "l")), new SpanTermQuery(new 
Term(FIELD, "m")), new SpanTermQuery(new Term(FIELD, "o"))
    }, 3, true, 2);
    Spans spans = q.createWeight(searcher, false, 
1f).getSpans(searcher.getIndexReader().leaves().get(0), 
SpanWeight.Postings.POSITIONS);
    assertFinished(spans);//but there should be a match!
  }
{code}

> Add minNumberShouldMatch parameter to SpanNearQuery
> ---------------------------------------------------
>
>                 Key: LUCENE-7434
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7434
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Tim Allison
>            Priority: Minor
>         Attachments: AllPairsNearSpans20160902.patch
>
>
> On the user list, [~saar32] asked about a new type of SpanQuery that would 
> allow for something like BooleanQuery's minimumNumberShouldMatch
> bq. Given a set of search terms (t1, t2, t3, ti), return all documents where 
> in a sequence of x=10 tokens at least c=3 of the search terms appear within 
> the sequence.
> I _think_ we can modify SpanNearQuery fairly easily to accommodate this.  
> I'll submit a PR in the next few days.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to