GitHub user dsmiley opened a pull request:
https://github.com/apache/lucene-solr/pull/76
UH round 3 (refactor to create FieldOffsetsEnum)
this time don't squash commit. I suspect squash commits might be fine in
more typical scenarios but in this back & forth collaboration I keep having to
repoint my branches at your newly squashed commits
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsmiley/lucene-solr unified_highlighter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 02e932c4a6146363680b88f4947a693c6697c955
Author: Timothy Rodriguez <[email protected]>
Date: 2016-09-01T19:23:50Z
Initial fork of PostingsHighlighter for UnifiedHighlighter
commit 9d88411b3985a98851384d78d681431dba710e89
Author: Timothy Rodriguez <[email protected]>
Date: 2016-09-01T23:17:06Z
Initial commit of the UnifiedHighlighter for OSS contribution
commit e45e39bc4b07ea33e4423b264c2fefb9aa08777a
Author: David Smiley <[email protected]>
Date: 2016-09-02T12:45:49Z
Fix misc issues; "ant test" now works. (#1)
commit 046a28ef31acf4cea7d255bbbb4b827e6a714e3d
Author: Timothy Rodriguez <[email protected]>
Date: 2016-09-02T20:58:31Z
Minor refactoring of the AnalysisFieldHighlighter
commit ffc2a22c700b8abcbf87673d5d05bb3659d177c9
Author: David Smiley <[email protected]>
Date: 2016-09-04T15:21:08Z
UnifiedHighlighter round 2 (#2)
* AbstractFieldHighlighter: order methods more sensibly; renamed a couple.
* Improve javadocs and @lucene.external/internal labeling & scope.
"ant precommit" now passes.
* Analysis: remove dubious filter() method
* getStrictPhraseHelper -> rm "Strict", getHighlightAccuracy -> getFlags,
and only call filterExtractedTerms once.
commit f6fd80544eae9fab953b94b1e9346c0883f956eb
Author: David Smiley <[email protected]>
Date: 2016-09-04T16:12:33Z
Refactor: FieldOffsetStrategy
commit b335a673c2ce45904890c1e9af7cbfda2bd27b0f
Author: David Smiley <[email protected]>
Date: 2016-09-04T16:21:32Z
stop passing maxPassages into highlightFieldForDoc()
commit 478db9437b92214cbf459f82ba2e3a67c966a150
Author: David Smiley <[email protected]>
Date: 2016-09-04T18:29:44Z
Rename subclasses of FieldOffsetStrategy.
commit dbf4280755c11420a5032445cd618fadb7444b61
Author: David Smiley <[email protected]>
Date: 2016-09-04T18:31:34Z
Re-order and harmonize params on methods called by UH.getFieldHighlighter()
commit f0340e27e61dcda2e11992f08ec07a72fad6c24c
Author: David Smiley <[email protected]>
Date: 2016-09-04T18:53:51Z
FieldHighlighter: harmonize field/param order. And don't apply
maxNoHighlightPasses twice.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
