Mike Drob created SOLR-9524:

             Summary: SolrIndexSearcher.getIndexFingerprint uses dubious 
                 Key: SOLR-9524
                 URL: https://issues.apache.org/jira/browse/SOLR-9524
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
    Affects Versions: 6.3
            Reporter: Mike Drob

In SOLR-9310 we added more code that does some fingerprint caching in 
SolrIndexSearcher. However, the synchronization looks like it could be made 
more efficient and may have issues with correctness.


Some of the issues:
* Double checked locking needs use of volatile variables to ensure proper 
memory semantics.
* sync on a ConcurrentHashMap is usually a code smell

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to