[ 
https://issues.apache.org/jira/browse/LUCENE-4968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503273#comment-15503273
 ] 

Michael McCandless commented on LUCENE-4968:
--------------------------------------------

bq.  What do you think about replacing it to meaningful advise to check parent 
and child filter for empty intersection?

Or maybe do both?  Patch?

> Several ToParentBlockJoinQuery/Collector issues
> -----------------------------------------------
>
>                 Key: LUCENE-4968
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4968
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/join
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.3.1, 6.0
>
>         Attachments: LUCENE-4968.patch
>
>
> I hit several issues with ToParentBlockJoinQuery/Collector:
>   * If a given Query sometimes has no child matches then we could hit
>     AIOOBE, but should just get 0 children for that parent
>   * TPBJC.getTopGroups incorrectly throws IllegalArgumentException
>     when the child query happens to have no matches
>   * We have checks that user didn't accidentally pass a child query
>     that matches parent docs ... they are only assertions today but I
>     think they should be real checks since it's easy to screw up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to