[ 
https://issues.apache.org/jira/browse/SOLR-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510749#comment-15510749
 ] 

Tomás Fernández Löbbe commented on SOLR-9545:
---------------------------------------------

Thanks for the patch [~gro], If I understand correctly, this code is executed 
when requesting a delta update but a "deltaImportQuery" was not configured, 
correct? In that case, the exception message is not correct. Also, could you 
make the exception a SolrException instead of a plain RuntimeException? and 
ideally add a unit test.

> DataImportHandler throws NPE to logs when pk attribute is not present when 
> delta query is used
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9545
>                 URL: https://issues.apache.org/jira/browse/SOLR-9545
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: contrib - DataImportHandler
>    Affects Versions: 6.2.1
>            Reporter: Rafał Kuć
>            Priority: Minor
>             Fix For: 6.3
>
>         Attachments: SOLR-9545.patch
>
>
> Hi, 
> Currently, when running a delta query from the Data Import Handler and pk 
> parameter is not specified Solr just logs NullPointerExeception, not 
> providing any information on what was expected. 
> Patch coming soon. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to