[ https://issues.apache.org/jira/browse/SOLR-9556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15519512#comment-15519512 ]
Alan Woodward commented on SOLR-9556: ------------------------------------- I've stepped through the code and I can't work out where the leak actually happens, but it seems that if the Overseer thread is started by its ElectionContext after everything else is shut down, then Overseer.close() doesn't get called. I think there are a couple of things we can do here: 1) Close the election threads right at the beginning of CoreContainer shutdown. This should help prevent spurious leader elections on closing nodes. 2) Always quit Overseer threads on interrupt. At the moment they check to see if they're closed first, but is there really any situation in which a thread is interrupted but it shouldn't then exit? > Overseer can leak threads if it starts up while its parent container is > shutting down > ------------------------------------------------------------------------------------- > > Key: SOLR-9556 > URL: https://issues.apache.org/jira/browse/SOLR-9556 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Alan Woodward > > See https://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Solaris/407/consoleFull > for an example. OverseerAutoReplicaFailoverThread is particularly > susceptible for some reason. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org