[ 
https://issues.apache.org/jira/browse/SOLR-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529090#comment-15529090
 ] 

Andrey Kudryavtsev commented on SOLR-9554:
------------------------------------------

{{ManagedIndexSchemaFactory#create}} contains a pretty cool code in terms of 
multithreading execution. 

But _it seems like_ even if there would be a race between several threads 
execute this code, it won't lead to that NPE that was logged in Jenkins job. I 
mean - {{loadedResource}} won't be {{null}} in [169 
line|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L169]
 due to race. It is just my understanding and it easily could be wrong.  

But still - NPE is here in Jenkins.

One of possible options - there was an {{IOException}} in [146 
line|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L146].
 That exception was lost, but as a result we could get {{loadedResource=null}} 
in 169 line. 

So why don't we start diving into this issue with this small change - log 
possible exception in catch block. I think it should be logged in any case.

> Multiple ManagedIndexSchemaFactory upgrades running simultaneously can clash, 
> causing cores not to load
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9554
>                 URL: https://issues.apache.org/jira/browse/SOLR-9554
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Alan Woodward
>         Attachments: SOLR-9554.patch, SOLR-9554.patch
>
>
> If a collection is created using a configset with a ManagedSchemaFactory but 
> no managed-schema file, then multiple cores may try and convert the schema 
> file simultaneously.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to