[
https://issues.apache.org/jira/browse/SOLR-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538598#comment-15538598
]
Varun Thacker commented on SOLR-5041:
-------------------------------------
Hi Dat/Shalin,
I was just going through this patch and I have a couple of doubts:
1. Is {[cloudClient.commit();}} needed in the
{{TestLeaderRecoverFromLogOnStartup}} test? It probably doesn't matter but just
wanted to know if I am missing something.
2. Should we extend {{SolrCloudTestCase}} instead of
{{AbstractFullDistribZkTestBase}} in the test?
> Add a test to make sure that a leader always recovers from log on startup
> -------------------------------------------------------------------------
>
> Key: SOLR-5041
> URL: https://issues.apache.org/jira/browse/SOLR-5041
> Project: Solr
> Issue Type: Test
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 6.3, master (7.0)
>
> Attachments: SOLR-5041.patch, SOLR-5401.patch
>
>
> From my comment on SOLR-4997:
> bq. I fixed a bug that I had introduced which skipped log recovery on startup
> for all leaders instead of only sub shard leaders. I caught this only because
> I was doing another line-by-line review of all my changes. We should have a
> test which catches such a condition.
> Add a test which tests that leaders always recover from log on startup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
